-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/9344 acrsubtlenotification component #9547
base: develop
Are you sure you want to change the base?
Conversation
…crsubtlenotification-component.
@@ -124,7 +124,7 @@ $c-yellow-y-900: #1f1400; | |||
$c-yellow-y-1000: #000; | |||
$c-violet-v-0: #fff; | |||
$c-violet-v-10: #fbf9ff; | |||
$c-violet-v-50: #dbc5ff; | |||
$c-violet-v-50: #e3d1ff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This color token has a new value in Figma, and since this variable was not used anywhere so far, I updated it's value instead of creating a duplicate variable with different value
Size Change: +701 B (+0.04%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
Build files for 7fc905d are ready:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @zutigrm, reviewed, tested and moving to MR.
Summary
Addresses issue:
ACRSubtleNotifciation
Subtle Notification Banner Component & Include in KMW Settings Area for Users Who Have Not Yet Set Up KMW, or Users With Manual KMW Setup #9344Relevant technical choices
Approach has been simplified a bit from what was originally written in IB. Notification could be included in one place only
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist