Method to set the input stream of a command #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of external programs are using stdin to pass data to the program Expose a function `setInput()` to specify a custom string that is gonna be written to the process's standard input. Test plan: added a new test and used the feature in one of my custom plugin.
erikvarga
requested changes
Dec 7, 2020
| @@ -83,4 +83,16 @@ public void getError_withMultipleGetOutputCalls_returnsExpect() | |||
| assertThat(executor.getError()).isEqualTo("1\n"); | |||
| assertThat(executor.getError()).isEqualTo("1\n"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void execute_writesInputIfSet() | |||
There was a problem hiding this comment.
Please use the format functionUnderTest_condition_expectedResult
e.g. something like execute_whenInputIsSet_writesInputToCommand
common/src/main/java/com/google/tsunami/common/command/CommandExecutor.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of external programs are using stdin to pass data to the program
Expose a function
setInput()to specify a custom string that is gonna be written to the process's standard input.Test plan: added a new test and used the feature in one of my custom plugin.