Publish docker images to docker hub (fixes #71)

[JonZeolla]

This adds a github action which will build and publish the docker image to docker hub.

Before merging, consider configuring the github repo with credentials for DOCKERHUB_USERNAME and DOCKERHUB_TOKEN

I am also open to pinning the commit hashes for the use of the third party actions of docker/login-action, docker/build-push-action , peter-evans/dockerhub-description.

[magl0]

LGTM. I will start our importing workflow. It might take a few hours to get reviewed internally.

[magl0]

Hi @JonZeolla, this PR probably needs more work.

Internal policy requires us to move dockerhub images to gcr.io. Since this image is new, we should directly host them on GCR. Tsunami team will set up a hosting GCP project and push images there. If you have bandwidth, can you update the workflow in this PR to publish to GCR instead (an example, please all the GKE stuff). Otherwise Tsunami team can take the remaining work over. Sorry for the additional complexity.

In addition, we are currently waiting for our internal reviews on the prebuilt docker images. This can take a while before the first public build.

[gaby]

@magl0 Would it be possible for the image to be published to both gcr.io and docker hub?

[magl0]

@magl0 Would it be possible for the image to be published to both gcr.io and docker hub?

Hi, technically it is possible to publish to both registries. But we are migrating away from docker hub and and in the future gcr.io will be the only option. We try to avoid doing throw-away work if possible to avoid maintenance burden.

[gaby]

@magl0 Would it be possible for the image to be published to both gcr.io and docker hub?

Hi, technically it is possible to publish to both registries. But we are migrating away from docker hub and and in the future gcr.io will be the only option. We try to avoid doing throw-away work if possible to avoid maintenance burden.

Makes sense, specially since gcr.io is owned by Google.

[RiRa12621]

hey @magl0 if this it still open, I could probably try to get a new PR up that publishes to gcr.