Fix subgroup_arithmetic benchmark for flexible subgroup sizes #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up source data values according to the subgroupSize device property. But inside the shader, measure the actual subgroup size, and pass it out of the shader. Then, adjust the verification logic to take that actual subgroup size into account. This still does the same amount of arithmetic as in the original code, and it does it in the same shape. Fixes: #45
antiagainst
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up source data values according to the subgroupSize device property. But inside the shader, measure the actual subgroup size, and pass it out of the shader. Then, adjust the verification logic to take that actual subgroup size into account.
This still does the same amount of arithmetic as in the original code, and it does it in the same shape.
Fixes: #45