Skip to content

Commit

Permalink
[CI] Remove CARGO_NET_RETRY override (#324)
Browse files Browse the repository at this point in the history
The caching introduced in #302 fixes the issue that this override
was meant to address, so it's no longer necessary.
  • Loading branch information
joshlf authored Sep 4, 2023
1 parent 4df931d commit 07854bc
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,6 @@ permissions: read-all

env:
CARGO_TERM_COLOR: always
# Increased from the default value of 3 in order to address #295. As of that issue's
# writing, we were experiencing a few failures per 149 jobs due to network timeouts.
# This implies a failure rate of (very roughly) 1 in 50. Assuming statistically
# independent network failures (probably a bad assumption, but we can't really do
# better without a lot more investigating), every subsequent 3 retries should reduce
# the incidence of failures 50-fold. Setting this to 9 should result in a failure
# rate of 1 in 125,000. Assuming 149 jobs per PR, we should expect at least one
# failure per set of 149 jobs to occur with 1 - (1 - (1/125000))^149 = 0.001%
# probability, which is plenty low enough to not meaningfully impact development.
CARGO_NET_RETRY: 9
RUSTFLAGS: -Dwarnings
RUSTDOCFLAGS: -Dwarnings
# `ZC_NIGHTLY_XXX` are flags that we add to `XXX` only on the nightly
Expand Down

0 comments on commit 07854bc

Please sign in to comment.