Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use compile-time assertions to deny ZSTy DSTs #1154

Merged
merged 1 commit into from
May 1, 2024
Merged

Use compile-time assertions to deny ZSTy DSTs #1154

merged 1 commit into from
May 1, 2024

Commits on May 1, 2024

  1. Use compile-time assertions to deny ZSTy DSTs 

    Presently, we deny ZSTy DSTs in our APIs via panicking at runtime. However, the
ZSTiness of a DST is statically detectable and can be denied instead at compile
time. This PR replaces our ZSTy DST panics with compile-time assertions. Doing
gives us the freedom later provide meaningful runtime semantics in such cases.

Partially addresses #325
Closes #1149
    @jswrenn @joshlf
    jswrenn authored and joshlf committed May 1, 2024
    Configuration menu
    Copy the full SHA
    03d13f9 View commit details
    Browse the repository at this point in the history