Relax pointer_to_metadata preconditions
#1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change argument type of `pointer_to_metadata` from `NonNull<Self>` to `*mut Self`, since the implementations of `pointer_to_metadata` do not actually require the argument to be non-null. I anticipate this change will make future code less verbose, as many standard library APIs return raw pointers, not `NonNull`; for example, `Box::into_raw`.
jswrenn
force-pushed
the
relax-pointer_to_metadata
branch
from
3d4ae27
to
95cb9a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1826 +/- ##
=======================================
Coverage 87.40% 87.41%
=======================================
Files 16 16
Lines 5995 5997 +2
=======================================
+ Hits 5240 5242 +2
Misses 755 755 ☔ View full report in Codecov by Sentry. |
joshlf
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change argument type of
pointer_to_metadatafromNonNull<Self>to*mut Self, since the implementations ofpointer_to_metadatado not actually require the argument to be non-null.I anticipate this change will make future code less verbose, as many standard library APIs return raw pointers, not
NonNull; for example,Box::into_raw.