Implement Hash for ByteOrder types
#1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1872 +/- ##
=======================================
Coverage 87.41% 87.41%
=======================================
Files 16 16
Lines 5997 5997
=======================================
Hits 5242 5242
Misses 755 755 ☔ View full report in Codecov by Sentry. |
jswrenn
force-pushed
the
byteorder-hash
branch
from
06dde5f
to
c0e000a
Compare
|
thanks that was fast |
joshlf
approved these changes
Oct 11, 2024
|
Updated so this PR releases 0.8.5 as well. |
joshlf
force-pushed
the
byteorder-hash
branch
from
c0e000a
to
5bfa6cd
Compare
The absence of these impls lead to the absence of `Hash` for the byteorder-aware numeric types. Release 0.8.5. Fixes #1871
joshlf
force-pushed
the
byteorder-hash
branch
from
5bfa6cd
to
d8e6e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The absence of these impls lead to the absence of
Hashfor the byteorder-aware numeric types.Fixes #1871