Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cargo manifest workspace keys #1884

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Oct 12, 2024

This allows zerocopy-derive to inherit some keys from the workspace configuration rather than having to specify them separately, which in turn allows us to remove some CI logic to check that they're the same.

I manually confirmed that the edit to ci/release_crate_versions.sh is correct.

Upgrade our MSRV to 1.65 and remove version detection logic prior to
that version.
While we're here, remove defensive programming against bug in
`Layout::from_size_align` which is no longer needed on our new MSRV.
This allows zerocopy-derive to inherit some keys from the workspace
configuration rather than having to specify them separately, which in
turn allows us to remove some CI logic to check that they're the same.

I manually confirmed that the edit to `ci/release_crate_versions.sh` is
correct.
@joshlf joshlf changed the base branch from main to msrv-1.65 October 12, 2024 15:03
@joshlf joshlf changed the title Cargo manifest workspace keys Use Cargo manifest workspace keys Oct 12, 2024
@joshlf joshlf added the blocked-on-dep Blocked on one of our dependencies making some change label Oct 12, 2024
@joshlf
Copy link
Member Author

joshlf commented Oct 12, 2024

Blocked on webern/cargo-readme#81

Base automatically changed from msrv-1.65 to main October 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-on-dep Blocked on one of our dependencies making some change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant