[pointer] Match variance of references #1894
Merged
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jswrenn Any ideas on how to test this? |
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
9ccd192
to
3ab2c00
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
3ab2c00
to
cf218f6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1894 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 17 17
Lines 5964 5964
=======================================
Hits 5228 5228
Misses 736 736 ☔ View full report in Codecov by Sentry. |
jswrenn
approved these changes
Oct 14, 2024
joshlf
force-pushed
the
ptr-invariant-file
branch
from
2f97c73
to
5f9ae12
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
cf218f6
to
77362c9
Compare
joshlf
force-pushed
the
ptr-invariant-file
branch
from
5f9ae12
to
d765097
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
77362c9
to
25de780
Compare
joshlf
force-pushed
the
ptr-invariant-file
branch
from
d765097
to
cad9c58
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
25de780
to
d96d763
Compare
joshlf
force-pushed
the
ptr-invariant-file
branch
from
cad9c58
to
5870ed6
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
d96d763
to
471f4a9
Compare
joshlf
force-pushed
the
ptr-invariant-file
branch
from
5870ed6
to
6e8def9
Compare
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
471f4a9
to
25ddf05
Compare
When the aliasing mode is `Any`, `Ptr<'a, T>` is invariant in `'a` and `T`. When the aliasing mode is `Shared` or `Exclusive`, `Ptr` has the same variance as `&'a T` and `&'a mut T` respectively. Makes progress on #1839
joshlf
force-pushed
the
ptr-variance-for-real
branch
from
25ddf05
to
87a434a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the aliasing mode is
Any,Ptr<'a, T>is invariant in'aandT. When the aliasing mode isSharedorExclusive,Ptrhas the same variance as&'a Tand&'a mut Trespectively.Makes progress on #1839