Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pointer][transmute] Migrate from util #1898

Draft
wants to merge 1 commit into
base: ptr-invariant-conversion-mapping
Choose a base branch
from

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Oct 13, 2024

This prepares us to rename TransparentWrapper to TransmuteFrom, which we'll do in a follow-up commit to preserve nice git diffs.

Makes progress on #1122

@joshlf joshlf requested a review from jswrenn October 13, 2024 01:34
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 5e5d01d to 231e3e3 Compare October 13, 2024 17:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 32.95455% with 59 lines in your changes missing coverage. Please review.

Project coverage is 87.61%. Comparing base (d176d7a) to head (38261ac).

Files with missing lines Patch % Lines
src/pointer/transmute.rs 39.18% 45 Missing ⚠️
src/util/macros.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           ptr-invariant-conversion-mapping    #1898   +/-   ##
=================================================================
  Coverage                             87.61%   87.61%           
=================================================================
  Files                                    17       18    +1     
  Lines                                  5943     5943           
=================================================================
  Hits                                   5207     5207           
  Misses                                  736      736           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 231e3e3 to c19a3e9 Compare October 14, 2024 14:58
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from c19a3e9 to 148380c Compare October 14, 2024 15:24
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 148380c to d2919d9 Compare October 14, 2024 15:30
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from d2919d9 to 3928ed2 Compare October 14, 2024 17:14
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 3928ed2 to 47de3c7 Compare October 14, 2024 17:34
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 47de3c7 to 2480958 Compare October 14, 2024 17:50
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from 2480958 to c3590eb Compare October 14, 2024 18:30
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from c3590eb to d176d7a Compare October 14, 2024 19:03
This prepares us to rename `TransparentWrapper` to `TransmuteFrom`,
which we'll do in a follow-up commit to preserve nice git diffs.

Makes progress on #1122
@joshlf joshlf force-pushed the ptr-invariant-conversion-mapping branch from d176d7a to 69792bc Compare October 14, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants