Bringing in service account string capability #871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the ability to provide credentials via an environment variable for use cases where adding a .json to the filesystem in the runtime environment is not feasible for security reasons.
Testing:
Called get_credentials in oauth2.py by declaring a
"json_key_string"
(item) with personal credentials inconfig_data
(dictionary)The result was that we received as a valid credentials object.
References:
Would highly recommend seeing this as similar approach has been executed in big query api library!
BQ: https://github.com/anelendata/tap-bigquery/blob/master/tap_bigquery/sync_bigquery.py
Implementation: https://gitlab.1password.io/data/data-issues/-/issues/3347#note_3160542