Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting for OS version for Windows and OS X by overriding the user … #121

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

loonychewy
Copy link

…agent

…agent

- Implemented using a mixture of code from the following sources
1. googleanalytics#78
1.1 For user agent override
2. googleanalytics#94
2.1 For the user agent string for Windows and OS X.
2.2 Includes a bit of extra code to fix a bug in Unity 4.6 where it reports Windows 10 as Windows 8.1 (6.3.10XXX), where the build number is correct
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

- Also implemented setCustomMetric and setCustomDimension for all LogXXX functions
@loonychewy
Copy link
Author

I've just signed the CLA

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants