Roll back to old version of got #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ofrobots
suggested changes
Jun 8, 2017
package.json
Outdated
| @@ -30,7 +30,7 @@ | |||
| "express": "^4.15.2", | |||
| "glob": "^7.0.3", | |||
| "google-auto-auth": "^0.7.0", | |||
| "got": "^7.0.0", | |||
| "got": "5.7.1", | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
New versions of got do not play well with async listener. The bug tracking this issue is here: othiym23/async-listener#112. Got is only a dev dependency used by the system tests so relying on an older version should be fine.
ofrobots
approved these changes
Jun 8, 2017
|
Windows x node 8 failure unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of got do not play well with async listener. The bug
tracking this issue is here:
othiym23/async-listener#112.
Got is only a dev dependency used by the system tests so relying on an
older version should be fine.