Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Metrics Trait #480

Closed
wants to merge 15 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 143 additions & 0 deletions src/MetricsTrait.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,143 @@
<?php
/*
* Copyright 2023 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

namespace Google\Auth;

/**
* Provides methods for fetching and updation of auth metrics headers.
*
* @internal
*/
trait MetricsTrait
{
public static $metricsHeaderKey = 'x-goog-api-client';

// Auth request type
public static $requestTypeAccessToken = 'auth-request-type/at';
public static $requestTypeIdToken = 'auth-request-type/it';
public static $requestTypeMdsPing = 'auth-request-type/mds';

// Credential type
public static $credTypeUser = 'cred-type/u';
public static $credTypeSaAssertion = 'cred-type/sa';
public static $credTypeSaJwt = 'cred-type/jwt';
public static $credTypeSaMds = 'cred-type/mds';
public static $credTypeSaImpersonate = 'cred-type/imp';
Copy link
Contributor

@bshaffer bshaffer Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least based on their usage in this PR, these should all be private by default. But I think I'd get rid of them all together and just replace their usage with the strings themselves - they're only used in one place each, and they're not variable, so they shouldn't be variables.

They could be constants, but as traits don't allow constants, it won't work here.


// TODO: Find a way to get the auth version
// Auth library version
public static $version = '10.0.0';
Copy link
Contributor

@bshaffer bshaffer Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest making this a placeholder function instead, like this:

private static getAuthLiberaryVersion(): string
{
    throw new LogicException('This must be implemented by the class which uses the trait');
}

Also, why is the placeholder 10.0.0?


public function getPhpAndAuthLibVersion()
{
return 'gl-php/' . PHP_VERSION . ' auth/' . self::$version;
}

/**
* Returns header string for token request with credentials obtained from
* Google Compute Engine.
*
* @param bool $isAccessTokenRequest Determins whether the request is
* for access token or identity token. `true` returns headers
* for access token and `false` returns for identity tokens.
* @return string
*/
public function getTokenRequestMdsHeader(bool $isAccessTokenRequest)
{
return $this->getDefaults($isAccessTokenRequest) . ' ' . self::$credTypeSaMds;
}

/**
* Returns header string for token request with Service Account Credentials.
*
* @param bool $isAccessTokenRequest Determins whether the request is
* for access token or identity token. `true` returns headers
* for access token and `false` returns for identity tokens.
* @return string
*/
public function getTokenRequestSaAssertionHeader(bool $isAccessTokenRequest)
{
return $this->getDefaults($isAccessTokenRequest) . ' ' . self::$credTypeSaAssertion;
}

/**
* Returns header string for token request with Impersonated Service Account Credentials.
*
* @param bool $isAccessTokenRequest Determins whether the request is
* for access token or identity token. `true` returns headers
* for access token and `false` returns for identity tokens.
* @return string
*/
public function getTokenRequestSaImpersonateHeader(bool $isAccessTokenRequest)
{
return $this->getDefaults($isAccessTokenRequest) . ' ' . self::$credTypeSaImpersonate;
}

/**
* Returns header string for token request with User Refresh Credentials.
*
* @param bool $isAccessTokenRequest Determins whether the request is
* for access token or identity token. `true` returns headers
* for access token and `false` returns for identity tokens.
* @return string
*/
public function getTokenRequestUserHeader(bool $isAccessTokenRequest)
{
return $this->getDefaults($isAccessTokenRequest) . ' ' . self::$credTypeUser;
}

/**
* Returns header string for metadata server ping request.
*/
public function getMdsPingHeader()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to say without seeing where these methods will be implemented, but I am fairly confident these methods can all be private, as they'll be used internally to whatever class is making these calls.

{
return $this->getPhpAndAuthLibVersion()
. ' ' . self::$requestTypeMdsPing;
}

/**
* Apply the auth metrics header to `x-goog-api-client` key of the `$headers`
* properly and return updated headers.
*
* @param array $headers The headers to update.
* @param string $metricsHeaderToApply Auth metrics header value to apply
* @return array Updated headers value.
*/
public function applyAuthMetricsHeaders(array $headers, string $metricsHeaderToApply)
{
if ($metricsHeaderToApply == '') {
return $headers;
} elseif (isset($headers[self::$metricsHeaderKey])) {
$headers[self::$metricsHeaderKey][0] .= ' ' . $metricsHeaderToApply;
} else {
$headers[self::$metricsHeaderKey] = [$metricsHeaderToApply];
}
return $headers;
}

private function getDefaults(bool $forAccessToken = true)
{
$result = $this->getPhpAndAuthLibVersion();
if ($forAccessToken) {
$result .= ' ' . self::$requestTypeAccessToken;
} else {
$result .= ' ' . self::$requestTypeIdToken;
}
return $result;
}

}
118 changes: 118 additions & 0 deletions tests/MetricsTraitTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
<?php
/*
* Copyright 2023 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

namespace Google\Auth\Tests;

use Google\Auth\MetricsTrait;
use PHPUnit\Framework\TestCase;

class MetricsTraitTest extends TestCase
{
// TODO: Find a way to get the auth version
private const VERSION = '10.0.0';

private $impl;
private $phpAndAuthVersion;
private $defaultForAccessTokenRequest;
private $defaultForIdTokenRequest;
public function setUp(): void
{
$this->impl = new MetricsTraitImplementation();
$this->phpAndAuthVersion = 'gl-php/' . PHP_VERSION
. ' auth/' . self::VERSION;
$this->defaultForAccessTokenRequest = $this->phpAndAuthVersion
. ' ' . $this->impl::$requestTypeAccessToken;
$this->defaultForIdTokenRequest = $this->phpAndAuthVersion
. ' ' . $this->impl::$requestTypeIdToken;
}

public function testGetPhpAndAuthLibVersion()
{
$this->assertEquals(
$this->phpAndAuthVersion,
$this->impl->getPhpAndAuthLibVersion()
);
}

public function testGetDefaults()
{
// For access token
$this->assertEquals(
$this->defaultForAccessTokenRequest,
$this->impl->getDefaults($isAccessTokenRequest = true)
);

// For identity token
$this->assertEquals(
$this->defaultForIdTokenRequest,
$this->impl->getDefaults($isAccessTokenRequest = false)
);
}

/**
* @dataProvider getTokenRequestHeaderCases
* @param bool $isAccessTokenRequest
* @param string $credType
* @param string $expected
*/
public function testGetTokenRequestHeaders(
bool $isAccessTokenRequest,
string $credType,
string $expected
) {
$defaultHeader = $isAccessTokenRequest ?
$this->defaultForAccessTokenRequest :
$this->defaultForIdTokenRequest;
$expectedResult = $defaultHeader . ' ' . $expected;

$testMethodName = 'getTokenRequest' . $credType . 'Header';
$this->assertEquals(
$expectedResult,
$this->impl->$testMethodName($isAccessTokenRequest)
);
}

public function testGetMdsPingHeader()
{
$this->assertEquals(
$this->phpAndAuthVersion . ' ' . $this->impl::$requestTypeMdsPing,
$this->impl->getMdsPingHeader()
);
}

public function getTokenRequestHeaderCases()
{
$impl = new MetricsTraitImplementation();
return [
[true, 'Mds', $impl::$credTypeSaMds],
[false, 'Mds', $impl::$credTypeSaMds],
[true, 'SaAssertion', $impl::$credTypeSaAssertion],
[false, 'SaAssertion', $impl::$credTypeSaAssertion],
[true, 'SaImpersonate', $impl::$credTypeSaImpersonate],
[false, 'SaImpersonate', $impl::$credTypeSaImpersonate],
[true, 'User', $impl::$credTypeUser],
[false, 'User', $impl::$credTypeUser]
];
}
}

class MetricsTraitImplementation
{
use MetricsTrait {
getDefaults as public;
}
}