Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vcpkg to 2024-10-21 #14816

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented Oct 31, 2024

This change is Reviewable

@ddelgrosso1 ddelgrosso1 marked this pull request as ready for review October 31, 2024 16:53
@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner October 31, 2024 16:53
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (d58ddd2) to head (59d1290).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14816      +/-   ##
==========================================
- Coverage   93.27%   93.27%   -0.01%     
==========================================
  Files        2319     2319              
  Lines      208297   208410     +113     
==========================================
+ Hits       194297   194390      +93     
- Misses      14000    14020      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc
Copy link
Member

dbolduc commented Oct 31, 2024

Hm. It seems like the jump from c-ares 1.33.1 -> 1.34.1 in vcpkg is causing grpc::GoogleDefaultCredentials() to assert in our tests on windows. I don't know why. 🙃

@ddelgrosso1
Copy link
Contributor Author

grpc/grpc#37969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants