Skip to content

Commit

Permalink
test(all): fix multiple files in significant changes in continuous tests
Browse files Browse the repository at this point in the history
`if [ -z $SIGNIFICANT_CHANGES ]; then`

gets translated to for example:

```
+ '[' -z storage/grpc_client.go storage/integration_test.go ']'
```
Which causes the error:
```
github/google-cloud-go/internal/kokoro/continuous.sh: line 162: [: storage/grpc_client.go: binary operator expected
```
  • Loading branch information
BrennaEpp authored Dec 21, 2024
1 parent 145ddf4 commit a2d875f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/kokoro/continuous.sh
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ if [[ $KOKORO_JOB_NAME == *"continuous"* ]]; then
# Continuous jobs only run root tests & tests in submodules changed by the PR.
SIGNIFICANT_CHANGES=$(git --no-pager diff --name-only $KOKORO_GIT_COMMIT^..$KOKORO_GIT_COMMIT | grep -Ev '(\.md$|^\.github|\.json$|\.yaml$)' || true)

if [ -z $SIGNIFICANT_CHANGES ]; then
if [[ -z $SIGNIFICANT_CHANGES ]]; then
echo "No changes detected, skipping tests"
exit 0
fi
Expand Down

0 comments on commit a2d875f

Please sign in to comment.