Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): add UsesEmulator field to Client #11359

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raymonstah
Copy link

@raymonstah raymonstah commented Jan 1, 2025

Adds a boolean flag to determine if the client is connected to the emulator. Checking the UsesEmulator boolean is a safeguard where there may be multiple instantiated clients.

@raymonstah raymonstah requested review from a team as code owners January 1, 2025 07:15
Copy link

google-cla bot commented Jan 1, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Jan 1, 2025
Copy link
Contributor

@bhshkh bhshkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Rename UsingEmulator to UsesEmulator

@raymonstah raymonstah requested a review from bhshkh January 3, 2025 19:15
@bhshkh bhshkh linked an issue Jan 5, 2025 that may be closed by this pull request
@raymonstah raymonstah changed the title feat(firestore): add UsingEmulator field to Client feat(firestore): add UsesEmulator field to Client Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firestore: enable a flag when emulator is used
2 participants