Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): Add known failures for unimplemented features #11453

Merged
merged 3 commits into from
Jan 16, 2025
Merged

test(bigtable): Add known failures for unimplemented features #11453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f97ed24
test(bigtable): Add known failures for unimplemented features
bhshkh Jan 15, 2025
be8970c
correct the path
bhshkh Jan 16, 2025
1b15253
Merge branch 'main' into chore/known-failures
bhshkh Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bigtable/conformance_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ cd $conformanceTestsHome
# Tests in https://github.com/googleapis/cloud-bigtable-clients-test/tree/main/tests can only be run on go1.22.7
go install golang.org/dl/go1.22.7@latest
go1.22.7 download
go1.22.7 test -v -proxy_addr=:$testProxyPort | tee -a $sponge_log
# known_failures.txt contains tests for the unimplemented features
eval "go1.22.7 test -v -proxy_addr=:$testProxyPort -skip `tr -d '\n' < $testProxyHome/known_failures.txt` | tee -a $sponge_log"
RETURN_CODE=$?

echo "exiting with ${RETURN_CODE}"
Expand Down
10 changes: 10 additions & 0 deletions bigtable/internal/testproxy/known_failures.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
TestMutateRows_Retry_WithRoutingCookie\|
TestMutateRows_Retry_WithRetryInfo\|
TestReadRow_Retry_WithRoutingCookie\|
TestReadRow_Retry_WithRetryInfo\|
TestReadRows_Retry_WithRoutingCookie\|
TestReadRows_Retry_WithRoutingCookie_MultipleErrorResponses\|
TestReadRows_Retry_WithRetryInfo\|
TestReadRows_Retry_WithRetryInfo_MultipleErrorResponse\|
TestSampleRowKeys_Retry_WithRoutingCookie\|
TestSampleRowKeys_Retry_WithRetryInfo
Loading