Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [kms] code documentation improvements #5689

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Sep 19, 2024

  • Regenerate this pull request now.

PiperOrigin-RevId: 706891520

Source-Link: googleapis/googleapis@edbf799

Source-Link: https://github.com/googleapis/googleapis-gen/commit/dfaa23804906a3cdb63208e654a378c3d9a1d586
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWttcy8uT3dsQm90LnlhbWwiLCJoIjoiZGZhYTIzODA0OTA2YTNjZGI2MzIwOGU2NTRhMzc4YzNkOWExZDU4NiJ9

BEGIN_NESTED_COMMIT
docs: [kms] A comment for enum CryptoKeyVersionAlgorithm is changed
PiperOrigin-RevId: 700331075

Source-Link: googleapis/googleapis@3b7310b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/9eda366d22f320ed4d4d5ca9f1d58bbe6efb8805
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWttcy8uT3dsQm90LnlhbWwiLCJoIjoiOWVkYTM2NmQyMmYzMjBlZDRkNGQ1Y2E5ZjFkNThiYmU2ZWZiODgwNSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: [kms] Add GroundedGenerationService API
feat: Add AdvancedCompleteQuery API
feat: Add lite search API to allow public website search with API key
feat: Add Sitemap APIs to preview channel
feat: Support search personalization to preview channel
feat: Support natural language understanding search
feat: Add BillingEstimation in data store
feat: Support Google Workspace search
feat: Support advanced boost search
feat: Add one_box_page_size on search
feat: support query regex in control match rules
docs: deprecate extractive_answers in answer generation
docs: deprecate asynchronous mode in answer generation
docs: keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 691212731

Source-Link: googleapis/googleapis@e6b6ff9

Source-Link: https://github.com/googleapis/googleapis-gen/commit/67144fd43c5a3e164410b3617e5752f2e066ec25
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWttcy8uT3dsQm90LnlhbWwiLCJoIjoiNjcxNDRmZDQzYzVhM2UxNjQ0MTBiMzYxN2U1NzUyZjJlMDY2ZWMyNSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix!: [kms] Pagination feature is introduced for method ListKeyHandles in service Autokey
feat: Adding a state field for AutokeyConfig

docs: Field service_resolvers in message .google.cloud.kms.v1.EkmConnection is Explicitly is marked as to have field behavior of Optional

docs: A comment for field destroy_scheduled_duration in message .google.cloud.kms.v1.CryptoKey is updated for the default duration
PiperOrigin-RevId: 676068244

Source-Link: googleapis/googleapis@42492c9

Source-Link: https://github.com/googleapis/googleapis-gen/commit/47432180bdfba879fc7f82c4c451181702f25009
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWttcy8uT3dsQm90LnlhbWwiLCJoIjoiNDc0MzIxODBiZGZiYTg3OWZjN2Y4MmM0YzQ1MTE4MTcwMmYyNTAwOSJ9
END_NESTED_COMMIT

… service `Autokey`

feat: Adding a state field for AutokeyConfig

docs: Field service_resolvers in message .google.cloud.kms.v1.EkmConnection is Explicitly is marked as to have field behavior of Optional

docs: A comment for field `destroy_scheduled_duration` in message `.google.cloud.kms.v1.CryptoKey` is updated for the default duration
PiperOrigin-RevId: 676068244

Source-Link: googleapis/googleapis@42492c9

Source-Link: googleapis/googleapis-gen@4743218
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWttcy8uT3dsQm90LnlhbWwiLCJoIjoiNDc0MzIxODBiZGZiYTg3OWZjN2Y4MmM0YzQ1MTE4MTcwMmYyNTAwOSJ9
@dpebot
Copy link
Collaborator

dpebot commented Sep 19, 2024

/gcbrun

@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review September 19, 2024 00:15
@gcf-owl-bot gcf-owl-bot bot requested review from yoshi-approver and a team as code owners September 19, 2024 00:15
@dpebot
Copy link
Collaborator

dpebot commented Sep 19, 2024

/gcbrun

@sofisl sofisl added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 20, 2024
@sofisl
Copy link
Contributor

sofisl commented Sep 20, 2024

This is actually a breaking change. Let's wait until Node 18 since we can bundle these breaking changes together.

@danielbankhead danielbankhead added semver: major Hint for users that this is an API breaking change. next major: breaking change this is a change that we should wait to bundle into the next major version labels Oct 7, 2024
feat: Add AdvancedCompleteQuery API
feat: Add lite search API to allow public website search with API key
feat: Add Sitemap APIs to preview channel
feat: Support search personalization to preview channel
feat: Support natural language understanding search
feat: Add BillingEstimation in data store
feat: Support Google Workspace search
feat: Support advanced boost search
feat: Add one_box_page_size on search
feat: support query regex in control match rules
docs: deprecate extractive_answers in answer generation
docs: deprecate asynchronous mode in answer generation
docs: keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 691212731

Source-Link: googleapis/googleapis@e6b6ff9

Source-Link: googleapis/googleapis-gen@67144fd
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWttcy8uT3dsQm90LnlhbWwiLCJoIjoiNjcxNDRmZDQzYzVhM2UxNjQ0MTBiMzYxN2U1NzUyZjJlMDY2ZWMyNSJ9
@gcf-owl-bot gcf-owl-bot bot changed the title fix!: [kms] Pagination feature is introduced for method ListKeyHandles in service Autokey feat: [kms] Add GroundedGenerationService API Oct 30, 2024
@dpebot
Copy link
Collaborator

dpebot commented Oct 30, 2024

/gcbrun

Copy link

snippet-bot bot commented Oct 30, 2024

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dpebot
Copy link
Collaborator

dpebot commented Oct 30, 2024

/gcbrun

PiperOrigin-RevId: 700331075

Source-Link: googleapis/googleapis@3b7310b

Source-Link: googleapis/googleapis-gen@9eda366
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWttcy8uT3dsQm90LnlhbWwiLCJoIjoiOWVkYTM2NmQyMmYzMjBlZDRkNGQ1Y2E5ZjFkNThiYmU2ZWZiODgwNSJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat: [kms] Add GroundedGenerationService API docs: [kms] A comment for enum CryptoKeyVersionAlgorithm is changed Nov 26, 2024
@dpebot
Copy link
Collaborator

dpebot commented Nov 26, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Nov 26, 2024

/gcbrun

PiperOrigin-RevId: 706891520

Source-Link: googleapis/googleapis@edbf799

Source-Link: googleapis/googleapis-gen@dfaa238
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWttcy8uT3dsQm90LnlhbWwiLCJoIjoiZGZhYTIzODA0OTA2YTNjZGI2MzIwOGU2NTRhMzc4YzNkOWExZDU4NiJ9
@gcf-owl-bot gcf-owl-bot bot changed the title docs: [kms] A comment for enum CryptoKeyVersionAlgorithm is changed docs: [kms] code documentation improvements Dec 17, 2024
@dpebot
Copy link
Collaborator

dpebot commented Dec 17, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Dec 17, 2024

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. next major: breaking change this is a change that we should wait to bundle into the next major version owl-bot-copy semver: major Hint for users that this is an API breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants