Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update TransferManagerUtils#createBlobName to only use the file name instead of the full file path (#2573) #2679

Closed
wants to merge 1 commit into from

Conversation

chalmagr
Copy link

@chalmagr chalmagr commented Aug 20, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2573

If you write sample code, please follow the samples format.

@chalmagr chalmagr requested a review from a team as a code owner August 20, 2024 17:39
Copy link

google-cla bot commented Aug 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Aug 20, 2024
@sydney-munro
Copy link
Collaborator

Thanks for your contribution, unfortunately this would introduce a breaking change into an already GA feature in our client. We cannot accept this PR.

@chalmagr
Copy link
Author

chalmagr commented Oct 5, 2024

Thanks for your contribution, unfortunately this would introduce a breaking change into an already GA feature in our client. We cannot accept this PR.

Hi @sydney-munro,

I don't think that this GA feature is of any use the way it works today. Whoever may be using this, they would need to expect that the destination files will be located mimicking the source directory structure (see my comment on #2573)

We could add some flag to enable this behavior, but I believe that this feature is rendered unusable because of this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support StripPrefix on upload for TransferManager
2 participants