fix: return a non null list #3747
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| on: | |
| pull_request: | |
| name: verify_library_generation | |
| jobs: | |
| should-run-library-generation-tests: | |
| runs-on: ubuntu-22.04 | |
| outputs: | |
| should_run: ${{ steps.get_changed_directories.outputs.should_run }} | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 0 | |
| - name: get changed directories in the pull request | |
| id: get_changed_directories | |
| shell: bash | |
| run: | | |
| set -ex | |
| # PRs that come from a fork need to be handled differently | |
| if [[ ${head_repo_name} == ${base_repo} ]]; then | |
| git checkout ${base_ref} | |
| git checkout ${head_ref} | |
| changed_directories="$(git diff --name-only ${base_ref} ${head_ref})" | |
| else | |
| git remote add fork ${head_repo_url} | |
| git fetch fork # create a mapping of the fork | |
| git checkout -b "${head_ref}" fork/${head_ref} | |
| changed_directories="$(git diff --name-only "fork/${head_ref}" "origin/${base_ref}")" | |
| fi | |
| if [[ ${changed_directories} =~ "hermetic_build/" ]]; then | |
| echo "should_run=true" >> $GITHUB_OUTPUT | |
| else | |
| echo "should_run=false" >> $GITHUB_OUTPUT | |
| fi | |
| env: | |
| base_ref: ${{ github.event.pull_request.base.ref }} | |
| head_ref: ${{ github.event.pull_request.head.ref }} | |
| head_repo_url: ${{ github.event.pull_request.head.repo.html_url }} | |
| head_repo_name: ${{ github.event.pull_request.head.repo.full_name }} | |
| base_repo: ${{ github.repository }} | |
| library-generation-integration-tests: | |
| runs-on: ubuntu-22.04 | |
| needs: should-run-library-generation-tests | |
| if: needs.should-run-library-generation-tests.outputs.should_run == 'true' | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: actions/setup-python@v5 | |
| with: | |
| python-version: 3.12 | |
| - name: install python modules and dependencies | |
| shell: bash | |
| run: | | |
| set -ex | |
| pip install --upgrade pip | |
| pip install --require-hashes -r hermetic_build/common/requirements.txt | |
| pip install hermetic_build/common | |
| pip install --require-hashes -r hermetic_build/library_generation/requirements.txt | |
| pip install hermetic_build/library_generation | |
| - name: Run integration tests | |
| shell: bash | |
| run: | | |
| set -x | |
| python -m unittest hermetic_build/library_generation/tests/integration_tests.py | |
| library-generation-unit-tests: | |
| runs-on: ubuntu-22.04 | |
| needs: should-run-library-generation-tests | |
| if: needs.should-run-library-generation-tests.outputs.should_run == 'true' | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: actions/setup-python@v5 | |
| with: | |
| python-version: 3.12 | |
| - name: install python modules and dependencies | |
| shell: bash | |
| run: | | |
| set -ex | |
| pip install --upgrade pip | |
| pip install --require-hashes -r hermetic_build/common/requirements.txt | |
| pip install hermetic_build/common | |
| pip install --require-hashes -r hermetic_build/library_generation/requirements.txt | |
| pip install hermetic_build/library_generation | |
| pip install --require-hashes -r hermetic_build/release_note_generation/requirements.txt | |
| pip install hermetic_build/release_note_generation | |
| - name: Run shell unit tests | |
| run: | | |
| set -x | |
| hermetic_build/library_generation/tests/generate_library_unit_tests.sh | |
| - name: Run python unit tests | |
| run: | | |
| set -x | |
| python -m unittest discover -s hermetic_build -p "*unit_tests.py" | |
| library-generation-lint-shell: | |
| runs-on: ubuntu-22.04 | |
| needs: should-run-library-generation-tests | |
| if: needs.should-run-library-generation-tests.outputs.should_run == 'true' | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Run ShellCheck | |
| uses: ludeeus/[email protected] | |
| with: | |
| scandir: 'hermetic_build' | |
| format: tty | |
| severity: error | |
| library-generation-lint-python: | |
| runs-on: ubuntu-22.04 | |
| needs: should-run-library-generation-tests | |
| if: needs.should-run-library-generation-tests.outputs.should_run == 'true' | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: actions/setup-python@v5 | |
| with: | |
| python-version: 3.12 | |
| - name: install python dependencies | |
| shell: bash | |
| run: | | |
| set -ex | |
| pip install --upgrade pip | |
| pip install --require-hashes -r hermetic_build/common/requirements.txt | |
| pip install hermetic_build/common | |
| pip install --require-hashes -r hermetic_build/library_generation/requirements.txt | |
| pip install hermetic_build/library_generation | |
| pip install --require-hashes -r hermetic_build/release_note_generation/requirements.txt | |
| pip install hermetic_build/release_note_generation | |
| - name: Lint | |
| shell: bash | |
| run: | | |
| # exclude generated golden files | |
| # exclude owlbot until further refaction | |
| black --check hermetic_build --exclude "(library_generation/tests/resources/goldens)" |