chore: add a Cloud Build config to push library generation image to Artifact Registry #3251
Conversation
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| timeout: 7200s # 2 hours | |||
| substitutions: | |||
| _IMAGE_NAME: "gcr.io/cloud-devrel-public-resources/java-library-generation" | |||
| _IMAGE_NAME: "us-docker.pkg.dev/java-hermetic-build-prod/java-hermetic-build-prod-images" | |||
There was a problem hiding this comment.
I think the project name java-hermetic-build-prod is a generated name from java-hermetic-build? I don't think we need to repeat java-hermetic-build-prod again in the image name. Can we choose a different image name? library-generation actually sounds fine to me, but you may have a better idea.
There was a problem hiding this comment.
I'll take a look about how to change the image name.
There was a problem hiding this comment.
Repository name updated in cl/679753674.
This is the issue we ran into when pushing images to Artifact registry (which is different from pulling image from AR). |
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: s
JoeWang1127
changed the title
|
|
||
| timeout: 7200s # 2 hours | ||
| substitutions: | ||
| _IMAGE_NAME: "us-docker.pkg.dev/java-hermetic-build-prod/java-hermetic-build-prod-images" |
There was a problem hiding this comment.
I think this name needs to be updated with repository name as well?
| id: library-generation-build | ||
| waitFor: ["-"] | ||
|
|
||
| options: |
There was a problem hiding this comment.
I think this config is a test to try to resolve some permission issue? Did we find it useful?
There was a problem hiding this comment.
I think you mean the logging options.
Yes, we can see logs in cloud build.
|
|
In this PR:
This PR will allow us to push the library generation image to two image repositories so that we can test our generation script can pull from
us-docker.pkg.devwhile the downstream libraries can still use images fromgcr.io.Repository name changed in cl/679753674
Cloud build trigger changed in cl/680040538