[write-fonts] Post builder fixups #576
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that we compute the num_glyphs value, and provide defaults for the legacy 'min_mem_XXX' fields. It also replaces the `new_v2` method with methods for adding string data to an existing table. I couldn't decide on what the actual API should be here, but I didn't like that `new_v2` added defaults for the standard fields.
anthrotype
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
this looks better than before. We should also make sure that if the caller does not set glyph names, we default to post version 3.0, not 1.0 (which is legacy mac thing)
|
ah okay good catch! |
|
That's actually an interesting complication for codegen, this is the first time where we will have a lower version of a table (2.0) that has more fields than a higher version (3.0). We make a bunch of assumptions about fields only being added with versions, so I'll have to think about this some. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was looking for a little task while waiting for something else to finish and saw #548.
This closes #548, although not exactly as intended.
This is also a breaking change, so I'd prefer to hold it back until we have some more breaking stuff and we can merge it all together.
This makes it so that we compute the num_glyphs value, and provide defaults for the legacy 'min_mem_XXX' fields.
It also replaces the
new_v2method with methods for adding string data to an existing table. I couldn't decide on what the actual API should be here, but I didn't like thatnew_v2added defaults for the standard fields.