Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to make reproducing builds from crater easier #1039

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Oct 15, 2024

  • Set defaults on crater arguments and simplify example commands
  • Use the same default for local font repos in ttx_diff
  • Default ttx_diff to compare default because gftools doesn't actually do what it says at time of writing
  • Add the ability to run ttx_diff against a specific source in a repository
    • python resources/scripts/ttx_diff.py https://github.com/cyrealtype/Alice#sources/Alice.glyphs will check for a local copy of the repo, clone it if there isn't one, and then build/compare the glyphs file specified in the fragment
  • Document how to run ci locally to get an html report; very useful when trying to alter the html!
  • Add a copy repro button to the results

image

Copy repro gets you something like python resources/scripts/ttx_diff.py https://github.com/googlefonts/are-you-serious#sources/AreYouSerious.glyphs which ttx_diff now supports.

@rsheeter rsheeter changed the title WIP: Try to make interacting with crater easier Tweaks to make reproducing builds from crater easier Oct 15, 2024
@rsheeter rsheeter marked this pull request as ready for review October 15, 2024 19:34
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks like some nice improvements but I have concerns about the defaults, specifically ../fonts and to a lesser extent the results.json, more detail inline.

fontc_crater/README.md Show resolved Hide resolved
fontc_crater/src/args.rs Show resolved Hide resolved
fontc_crater/src/args.rs Outdated Show resolved Hide resolved
fontc_crater/src/args.rs Outdated Show resolved Hide resolved
fontc_crater/src/args.rs Outdated Show resolved Hide resolved
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so to summarize a discussion from chat:

  • we can just get rid of the 'fonts_repo' arg completely, it's a distraction. I've done that in [crater] Remove 'fonts_repo' cli arg #1041
  • for hard-coding a default cache location I would prefer something like .fontc_crater_cache, under the user's home directory. This isn't perfect, but a relative path won't work in the CI case (since we clone the fontc repo into a new working directory and then rm -rf it after each run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants