Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer subtool 'Scaling edit tool behavior' #1680

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

ollimeier
Copy link
Collaborator

@ollimeier ollimeier commented Sep 26, 2024

Fixes #1679

This is a draft PR, because I have some open questions:

  1. What would a good icon look like for the pointer tool with 'Scaling edit tool behavior'? (currently I used pointeradd.svg as a placeholder)
  2. Any ideas to improve the dropdown UI is much appreciated. Please see the following screenshot (with the rounded corners at the beginning):
Screenshot 2024-09-26 at 14 32 29

@ollimeier ollimeier changed the title First draft of pointer subtool 'Scaling edit tool behavior' Pointer subtool 'Scaling edit tool behavior' Sep 26, 2024
@justvanrossum
Copy link
Collaborator

Ha, a literal edge case :)

How about we add css that if the first tool is expanded, the lower left corner of the main tool strip is not rounded?

@justvanrossum
Copy link
Collaborator

Apart from the final icon design, this could be ready for review, right?

@ollimeier ollimeier marked this pull request as ready for review October 1, 2024 11:56
@ollimeier ollimeier merged commit 021ef65 into main Oct 1, 2024
3 checks passed
@ollimeier ollimeier deleted the issue-1679-scale-edit-tool branch October 1, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale edit tool should become a subtool of the pointer tool
3 participants