Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions to transformation panel #1687

Merged
merged 9 commits into from
Oct 3, 2024

Conversation

ollimeier
Copy link
Collaborator

Fixes #1683

@justvanrossum
Copy link
Collaborator

justvanrossum commented Oct 1, 2024

We have a fundamental problem here: the actions only get registered once the panel gets updated/shown. This means that if you hide the panel, then reload, any shortcuts do not work.

We somehow need to refactor this, but I need to think a bit more about how to best approach it.

Also: there is an existing bug where you get a console error message if you use one of the actions while there is no selection:
image

@ollimeier
Copy link
Collaborator Author

We have a fundamental problem here: the actions only get registered once the panel gets updated/shown. This means that if you hide the panel, then reload, any shortcuts do not work.

We somehow need to refactor this, but I need to think a bit more about how to best approach it.

Also: there is an existing bug where you get a console error message if you use one of the actions while there is no selection: image

I am not able to reproduce the error. Can you please let me know if this error still exists after my latest changes?

@justvanrossum
Copy link
Collaborator

Yes, the error still exists, but only in the "remove overlaps" action/button: make sure there is no selected glyph in the canvas, then push the "remove overlaps" button. (All other buttons appear to be fine in this case.)

@ollimeier
Copy link
Collaborator Author

Yes, the error still exists, but only in the "remove overlaps" action/button: make sure there is no selected glyph in the canvas, then push the "remove overlaps" button. (All other buttons appear to be fine in this case.)

Ah, I see. Thanks. I fixed it.

@ollimeier ollimeier force-pushed the issue-1683-actions-for-transformation-panel branch from 2c7d67d to 464aa1f Compare October 3, 2024 12:13
Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nits, then this is done I think.

src/fontra/views/editor/panel-transformation.js Outdated Show resolved Hide resolved
src/fontra/views/editor/panel-transformation.js Outdated Show resolved Hide resolved
@ollimeier ollimeier merged commit 99b8aa2 into main Oct 3, 2024
3 checks passed
@ollimeier ollimeier deleted the issue-1683-actions-for-transformation-panel branch October 3, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some transformation panel buttons should use actions.js, so they become "shortcuttable"
2 participants