propagate_anchors: fix handling of contextual anchors #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaledhosny
commented
Oct 5, 2024
khaledhosny
force-pushed
the
propagete-contextual-anchors
branch
from
e524564 to
920e45d
Compare
khaledhosny
added a commit
that referenced
this pull request
Oct 5, 2024
GlyphsApp does actually propagate them: #1037 (comment)
anthrotype
reviewed
Oct 7, 2024
anthrotype
reviewed
Oct 7, 2024
khaledhosny
added a commit
that referenced
this pull request
Oct 7, 2024
GlyphsApp does actually propagate them: #1037 (comment)
khaledhosny
force-pushed
the
propagete-contextual-anchors
branch
from
229a794 to
f2f75e9
Compare
anthrotype
reviewed
Oct 7, 2024
anthrotype
reviewed
Oct 7, 2024
- Don’t propagate contextual anchors, GlyphsApp does not propagate them. - When copying anchors, copy also userData, otherwise the context of contextual anchors of any processed glyph will be dropped. This is a regression from #1011
GlyphsApp does actually propagate them: #1037 (comment)
khaledhosny
force-pushed
the
propagete-contextual-anchors
branch
from
f2f75e9 to
1832f83
Compare
anthrotype
approved these changes
Oct 8, 2024
|
thank you Khaled |
schriftgestalt
pushed a commit
that referenced
this pull request
Oct 23, 2024
GlyphsApp does actually propagate them: #1037 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t propagate contextual anchors, GlyphsApp does not propagate them.It actually does, so this part is later reverted.