[postProcessor] fontTools.varLib.cff.convertCFFtoCFF2 is deprecated #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could we just bump the required fonttools instead? |
|
Fine by me. |
Try importing fontTools.cffLib.CFFToCFF2.convertCFFToCFF2 first, and confine the width stripping to when the deprecated method is used, as it is already fixed in FontTools.
khaledhosny
force-pushed
the
deprecation-warning
branch
from
85f07a4 to
41df6c1
Compare
anthrotype
approved these changes
Oct 16, 2024
It has the CFF to CFF2 fixes.
khaledhosny
force-pushed
the
deprecation-warning
branch
from
41df6c1 to
09cb94d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try importing fontTools.cffLib.CFFToCFF2.convertCFFToCFF2 first, and confine the width stripping to when the deprecated method is used, as it is already fixed in FontTools.