Skip to content

Commit

Permalink
Added missing env to flag mapping (#2728)
Browse files Browse the repository at this point in the history
On the allocator the following mapping were missing:

REMOTE_ALLOCATION_TIMEOUT
TOTAL_REMOTE_ALLOCATION_TIMEOUT
ALLOCATION_BATCH_WAIT_TIME

On the controller the following mapping was missing:

ALLOCATION_BATCH_WAIT_TIME

Co-authored-by: Robert Bailey <[email protected]>
  • Loading branch information
valentintorikian and roberthbailey authored Sep 3, 2022
1 parent 94de5b0 commit fd3dba6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions cmd/allocator/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@ func parseEnvFlags() config {
runtime.Must(viper.BindEnv(stackdriverLabels))
runtime.Must(viper.BindEnv(mTLSDisabledFlag))
runtime.Must(viper.BindEnv(tlsDisabledFlag))
runtime.Must(viper.BindEnv(remoteAllocationTimeoutFlag))
runtime.Must(viper.BindEnv(totalRemoteAllocationTimeoutFlag))
runtime.Must(viper.BindEnv(logLevelFlag))
runtime.Must(viper.BindEnv(allocationBatchWaitTime))
runtime.Must(viper.BindPFlags(pflag.CommandLine))
runtime.Must(runtime.FeaturesBindEnv())

Expand Down
3 changes: 2 additions & 1 deletion cmd/controller/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -308,13 +308,14 @@ func parseEnvFlags() config {
runtime.Must(viper.BindEnv(enableStackdriverMetricsFlag))
runtime.Must(viper.BindEnv(stackdriverLabels))
runtime.Must(viper.BindEnv(projectIDFlag))
runtime.Must(viper.BindPFlags(pflag.CommandLine))
runtime.Must(viper.BindEnv(numWorkersFlag))
runtime.Must(viper.BindEnv(apiServerSustainedQPSFlag))
runtime.Must(viper.BindEnv(apiServerBurstQPSFlag))
runtime.Must(viper.BindEnv(logLevelFlag))
runtime.Must(viper.BindEnv(logDirFlag))
runtime.Must(viper.BindEnv(logSizeLimitMBFlag))
runtime.Must(viper.BindEnv(allocationBatchWaitTime))
runtime.Must(viper.BindPFlags(pflag.CommandLine))
runtime.Must(runtime.FeaturesBindEnv())

runtime.Must(runtime.ParseFeaturesFromEnv())
Expand Down

0 comments on commit fd3dba6

Please sign in to comment.