Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node_pool with google_container_node_pool #3611

Closed
wants to merge 1 commit into from

Conversation

junekhan
Copy link

What type of PR is this?
/kind bug

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3339

Special notes for your reviewer:
I don't have a GCP account to verify this.

@github-actions github-actions bot added kind/bug These are bugs. size/M labels Jan 25, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1b772b2e-52e2-4785-b277-282012777a26

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3611/head:pr_3611 && git checkout pr_3611
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-450d8f5-amd64

Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also replay the "windows" node pool with google_container_node_pool?

@markmandel
Copy link
Member

Thanks for your PR of my livestream content from yesterday.

I'm going to close this, as I have the PR ready to go, and I can test on Google Cloud 😃

@markmandel markmandel closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GKE Standard/Terraform] Cluster nodes aren't upgrading with the control plane
4 participants