Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set externalTrafficPolicy as Local for agones-allocator #4022

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

osterante
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4019

Special notes for your reviewer:

Copy link

google-cla bot commented Oct 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added kind/feature New features for Agones size/XL labels Oct 23, 2024
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@osterante osterante force-pushed the feature/externalTrafficPolicy branch from 7c63f01 to c175db3 Compare October 23, 2024 15:34
@osterante osterante force-pushed the feature/externalTrafficPolicy branch from c175db3 to 730797d Compare October 23, 2024 15:41
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 31736da0-7429-405f-850f-30d51f1ee005

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@osterante osterante force-pushed the feature/externalTrafficPolicy branch from 730797d to 5784ef8 Compare October 24, 2024 10:10
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 0e9547eb-b205-4ee0-8aec-f206cc6c796e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4022/head:pr_4022 && git checkout pr_4022
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-5784ef8

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 8e767158-7ada-420a-9399-886636531b1a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4022/head:pr_4022 && git checkout pr_4022
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-a4cda57

@gongmax
Copy link
Collaborator

gongmax commented Nov 19, 2024

Discussed in the issue and thanks for the patience. Can you keep the default value unchanged for backward compatibility? And add a description for it here? It will need to be in a {{% feature publishVersion="1.46.0" %}} block similar as this, since we are release 1.45 today.

@osterante osterante force-pushed the feature/externalTrafficPolicy branch from 047ee9b to a3b683d Compare November 21, 2024 15:01
@osterante osterante force-pushed the feature/externalTrafficPolicy branch from a3b683d to 40846e6 Compare November 21, 2024 15:21
@gongmax
Copy link
Collaborator

gongmax commented Nov 27, 2024

/gcbrun

@gongmax gongmax enabled auto-merge (squash) November 27, 2024 17:18
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: cc659d3c-9577-4b35-905f-36d625696547

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4022/head:pr_4022 && git checkout pr_4022
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-7bee786

@gongmax gongmax merged commit 08bc4c0 into googleforgames:main Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set externalTrafficPolicy as Local for agones-allocator
3 participants