Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify bq_to_vcf integration tests to verify default 1-based coordinate #637

Open
samanvp opened this issue Jul 9, 2020 · 0 comments
Open

Comments

@samanvp
Copy link
Member

samanvp commented Jul 9, 2020

In #636 we added a new flag bq_uses_1_based_coordinate to allow users to export variants from BQ tables that are using either 0-baed on 1-based coordinate.

Note that our default value for coordinate (both bq_uses_1_based_coordinate and use_1_based_coordinate) is set to 1-based. That's why in #633 we updated all our integration tests to test the default path and added a few for testing 0-based.

We need to do the same thing for bq_to_vcf integration tests:

  • we should update their use_1_based_coordinate
  • we should remove "bq_uses_1_based_coordinate": false, line from the json files (so we will use the default True value).

Here is the list of tests that needs to be updated:

  • bq_to_vcf_tests/no_options.json
  • bq_to_vcf_tests/option_allow_incompatible_schema.json
  • bq_to_vcf_tests/option_customized_export.json
  • bq_to_vcf_tests/option_number_of_bases_per_shard.json
  • bq_to_vcf_tests/option_preserve_sample_order.json
  • bq_to_vcf_tests/option_representative_header_file.json
  • bq_to_vcf_tests/option_use_1_based_coordinate.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant