Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: recomposition demo, updates Camera #544

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

CaolanCode
Copy link

Hello,

In the recomposition demonstration the camera position is not updated with the marker position.
I have updated the camera position when the marker position is changed.
I've also used the location "signapore4" as it wasn't used.

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…tre the camera view when the location changes
Copy link

google-cla bot commented Apr 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@CaolanCode
Copy link
Author

I have signed the CLA

@kikoso kikoso changed the title [Issue: #543] Recomposition Demo: Update Camera chore: recomposition demo: Update Camera Apr 18, 2024
@kikoso kikoso changed the title chore: recomposition demo: Update Camera chore: recomposition demo, updates Camera Apr 18, 2024
@kikoso
Copy link
Collaborator

kikoso commented Apr 18, 2024

Hello and thanks for the PR, @CaolanCode ! I have updated the title to follow the semantic PR specification. Could you please update your commit name to follow the following convention?

@kikoso
Copy link
Collaborator

kikoso commented May 13, 2024

Hi @CaolanCode . Did you manage to see the previous message?

@CaolanCode
Copy link
Author

Hi @kikoso, thanks for the message. I've updated the sematics of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants