-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent Clustering with composable content from displaying default markers #615
base: main
Are you sure you want to change the base?
Conversation
…lt markers Wait until we have both a non-null clusterManager and renderer created before configuring the cluster manager listeners. This is a small optimization that prevents setting the listeners on the default renderer when the clusterManger is first created (before the renderer is created). Wait until the renderer is created before configuring the map for clustering. This prevents the default renderer from rendering markers.
Hi @darronschall , and thank you for this PR! Upon further checking it, it seems that using the two separate SideEffect blocks could have lead to race conditions, hence the reports on why this was not always reproducible. The explicit null check makes also the code safer in case of a race condition. I am still not able to reproduce it, but this should fix a potential concurrency issue. |
Probably fixes #549 |
I'd update this too: Lines 54 to 70 in 91b40fa
|
By the way, as I mentioned here, I really believe this is a bug in |
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #569 🦕