Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: null pointer exception in ClusterRenderer when continuously updating cluster item values #623

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix: null pointer exception in ClusterRenderer when continuously updating cluster item values #623

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
077f046
fix : view to be nullable
mohammad-firmansyah Sep 2, 2024
a4eb7dc
fix : put else condition when view.parent is null draw blank bitmap
mohammad-firmansyah Sep 2, 2024
6efea2e
Update maps-compose-utils/src/main/java/com/google/maps/android/compo…
mohammad-firmansyah Sep 4, 2024
2404b04
Update maps-compose-utils/src/main/java/com/google/maps/android/compo…
mohammad-firmansyah Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...compose-utils/src/main/java/com/google/maps/android/compose/clustering/ClusterRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ internal class ComposeUiClusterRenderer<T : ClusterItem>(
/* AndroidComposeView triggers LayoutNode's layout phase in the View draw phase,
so trigger a draw to an empty canvas to force that */
view.draw(fakeCanvas)
val viewParent = (view.parent as ViewGroup)
val viewParent =
view.parent as? ViewGroup ?: return Bitmap.createBitmap(20, 20, Bitmap.Config.ARGB_8888)
.let(BitmapDescriptorFactory::fromBitmap)
view.measure(
View.MeasureSpec.makeMeasureSpec(viewParent.width, View.MeasureSpec.AT_MOST),
View.MeasureSpec.makeMeasureSpec(viewParent.height, View.MeasureSpec.AT_MOST),
Expand Down