Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change the confusing parameter position to a clear name. #637 #638

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JSpiner
Copy link

@JSpiner JSpiner commented Oct 16, 2024

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #637 🦕

It may be confusing that it is automatically updated by the position parameter. I renamed it to initialPosition to make it clear that it only works with the initial value.
(The compose foundation libraries also add the init prefix to the initial values ​​that go into rememberXXX.)

Copy link

google-cla bot commented Oct 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@JSpiner JSpiner changed the title Change the confusing parameter position to a clear name. #637 chore: Change the confusing parameter position to a clear name. #637 Nov 4, 2024
@JSpiner
Copy link
Author

JSpiner commented Nov 4, 2024

I resolved the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Change the confusing markerState parameter position to a clear name.
2 participants