feat: add place-fields check to autocomplete (#15)

googlemaps · Dec 20, 2021 · b63718a · b63718a
1 parent 828bd15
commit b63718a
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/src/rules/place-fields.test.ts b/src/rules/place-fields.test.ts
@@ -38,8 +38,11 @@ new TSESLint.RuleTester({
     `const service = new google.maps.places.PlacesService();
     const buildRequest = () => {};
     service.getDetails(buildRequest())`,
+    // Autocomplete
+    `const service = new google.maps.places.Autocomplete(null, {fields: ['place_id']});`,
   ],
   invalid: [
+    // getDetails
     {
       code: `const service = new google.maps.places.PlacesService();
     const request = {place_id: 'foo'};
@@ -56,5 +59,10 @@ new TSESLint.RuleTester({
 service.getDetails({...{bar: 'foo'}})`,
       errors: [{ messageId }],
     },
+    // Autocomplete
+    {
+      code: `const service = new google.maps.places.Autocomplete(null, {});`,
+      errors: [{ messageId }],
+    },
   ],
 });
diff --git a/src/rules/place-fields.ts b/src/rules/place-fields.ts
@@ -37,6 +37,27 @@ export default createRule({
   defaultOptions: [],
   create: (context) => {
     return {
+      NewExpression: (node: TSESTree.NewExpression): void => {
+        try {
+          if (
+            fullNamespace(node.callee).match(
+              /google\.maps\.places\.Autocomplete/
+            )
+          ) {
+            const references = context.getScope().references;
+            const options = node.arguments[1];
+
+            if (objectMaybeHasKey(references, options) === Ternary.FALSE) {
+              context.report({
+                messageId,
+                node: node.arguments[1],
+              });
+            }
+          }
+        } catch (e) {
+          console.warn(`rule googlemaps/${__filename} failed with: ${e}`);
+        }
+      },
       MemberExpression: (node: TSESTree.MemberExpression): void => {
         try {
           if (