-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update caniuse-lite db to fix UMD build dependencies #548
base: main
Are you sure you want to change the base?
fix: Update caniuse-lite db to fix UMD build dependencies #548
Conversation
@wangela ptal |
@wangela Are you available to take a look at this PR? It is blocking us from upgrading out Google Maps packages to latest. |
This is quite annoying in packages using @googlemaps/url-signature as dependency, can someone review this so that a new version can be released? See #528 for a lot of people waiting on this. |
I just merged |
Head branch was pushed to by a user without write access
It appears that this might not be necessary anymore because updates to Babel have caused a bump to the |
@zackdotcomputer Thanks for noting that the issue has gone away. I can confirm that I could remove the override I had added to stick with 1.0.32, with version 1.0.36 the problem is not present any longer. I think this issue can thus be closed. |
This resolves the issue where the
.umd.js
build is including a reference torequire("core-js...")
This appears to be because an unrelated update caused an update to the caniuse-lite repository which incorrectly informs babel that this library should be required rather than polyfilled. This issue was fixed in the latest release of that repository, so updating it in the lockfile fixes the underlying issue.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #528 🦕