Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add display options to navigation #370

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

illuminati1911
Copy link
Contributor

@illuminati1911 illuminati1911 commented Dec 3, 2024

Adds display options to navigation:

/**
 * Defines the options used by the Navigator for dislaying different elements.
 */
export interface DisplayOptions {
  /**
   * Configures whether destination markers are shown during navigation.
   * If true, destination markers are shown.
   */
  showDestinationMarkers?: boolean;
  /**
   * Configures whether stop signs are shown during navigation.
   * If true, stop signs are shown.
   */
  showStopSigns?: boolean;
  /**
   * Configures whether traffic lights are shown during navigation.
   * If true, traffic lights are shown.
   */
  showTrafficLights?: boolean;
}
  • Tests pass
  • Appropriate changes to documentation are included in the PR

Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits

@@ -403,16 +403,27 @@ private void createWaypoint(Map map) {
}

@ReactMethod
public void setDestination(ReadableMap waypoint, @Nullable ReadableMap routingOptions) {
public void setDestination(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setDestination could call setDestinations internally with array containing only the given waypoint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illuminati1911 illuminati1911 merged commit a6fa22e into main Dec 4, 2024
13 checks passed
@illuminati1911 illuminati1911 deleted the feat/navigation-displayoptions branch December 4, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants