-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements compilation of the delete operator #461
Open
TobiasWienand
wants to merge
5
commits into
googleprojectzero:main
Choose a base branch
from
TobiasWienand:feature/delete-operator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+76
−6
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6378490
Implements compilation of the delete operator
TobiasWienand 08f0af5
Merge branch 'googleprojectzero:main' into feature/delete-operator
TobiasWienand f8ba804
Fixes style issues in delete operator compilation
TobiasWienand 530e509
bug fix for delete operator
TobiasWienand 5426623
Implements additional test for delete
TobiasWienand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
if (typeof output === 'undefined') output = console.log; | ||
|
||
const obj = { a: 1 }; | ||
console.log(delete obj.a); | ||
console.log(obj); | ||
|
||
const propName = 'b'; | ||
obj[propName] = 2; | ||
console.log(delete obj[propName]); | ||
console.log(obj); | ||
|
||
const arr = [1, 2, 3]; | ||
console.log(delete arr[1]); | ||
console.log(arr); | ||
|
||
const index = 0; | ||
console.log(delete arr[index]); | ||
console.log(arr); | ||
|
||
const nestedObj = { a: { b: 2 } }; | ||
console.log(delete nestedObj?.a?.b); | ||
console.log(nestedObj); | ||
|
||
try { | ||
delete null.a; | ||
} catch(e) { | ||
console.log(e.message); | ||
} | ||
console.log(delete null?.a); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add a test for something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is compilable. However, this would cause DeleteProperty to be called, even though null is not an object. In Compiler.swift, I believe it is currently not possible to check here if obj is truly an object. We could either
What would you prefer?