fix: Misplaced comment in code generates wrong code snippet in google doc - SpreadsheetAppendValues.php #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misplaced `[END sheets_append_values]` comment is generating incorrect code snippet in the google doc (I guess) see this code snippet, here we can see the function's closing brace is missing in the doc. https://developers.google.com/sheets/api/guides/values#append_values If I guessed it correctly then this issue is present in other code file as well.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
imskm
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
imskm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misplaced
[END sheets_append_values]comment is generating incorrect code snippet in the google doc (I guess)See this code snippet, here we can see the function's closing brace is missing in the doc.
https://developers.google.com/sheets/api/guides/values#append_values
If I guessed it correctly then this issue is present in other code file as well.