This repository has been archived by the owner on Sep 29, 2024. It is now read-only.
fix: UUID error #437
Closed
fix: UUID error #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshaplygin
reviewed
Apr 16, 2021
|
See updated 👍 |
sshaplygin
reviewed
Apr 16, 2021
| @@ -115,15 +119,10 @@ func newRedisBroadcast(nsp string, adapter *RedisAdapterOptions) (*redisBroadcas | |||
| return nil, err | |||
| } | |||
| sub, err := redis.Dial("tcp", redisAddr) | |||
| if err != nil { | |||
There was a problem hiding this comment.
why are you delete error check?
| bc.pub = redis.PubSubConn{Conn: pub} | ||
| bc.sub = redis.PubSubConn{Conn: sub} | ||
|
|
| @@ -89,6 +89,10 @@ type allRoomResponse struct { | |||
| Rooms []string | |||
| } | |||
|
|
|||
| func genUUID() string{ | |||
| return uuid.Must(uuid.NewV4()).String() | |||
There was a problem hiding this comment.
version uuid - https://github.com/googollee/go-socket.io/blob/master/go.mod#L9
not correct usage uuid.Must compile error by v1.2.0
have (uuid.UUID)
want (uuid.UUID, error)
There was a problem hiding this comment.
we need download mod uuid by hash commit
There was a problem hiding this comment.
This works fine. It will never throw an error. Must will make it panic instead.
There was a problem hiding this comment.
please use this command at main go-socket.io directory.
go get github.com/satori/go.uuid@b2ce2384e17bbe0c6d34077efa39dbab3e09123b
|
Thanks for help, but it does nit actually :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the error
error multiple-value uuid.NewV4() in single-value context.Replaced
uuid.NewV4().String()withuuid.Must(uuid.NewV4()).String()