Replace hashicorp/go-uuid import with gofrs/uuid #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awels
changed the title
|
I am not sure why MPL would be incompatible with this project, but I like the idea of switching to a compliant UUIDv4 generator. What do you think of https://github.com/gofrs/uuid which is also MIT? |
|
MPL 2.0 is not compatible with Apache 2.0. The project I work on has a license scanner and it flagged the go-uuid dependency as incompatible. I traced it coming from gophercloud as we don't import it ourselves. I am fine with gofrs. I picked the google one, but if you prefer gofrs that works for me. |
Replace import of hashicorp/go-uuid as its license is not incompatible with the license of the project. Instead use gofrs/uuid which is compatible. It uses an MIT license. Signed-off-by: Alexander Wels <[email protected]>
awels
changed the title
|
Well, thank you then! |
|
Updated the PR to replace it with gofrs/uuid instead. |
pierreprinetti
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace import of hashicorp/go-uuid as its license MPL 2.0 is not incompatible with the license of the project Apache 2.0. Instead use gofrs/uuid which is compatible. It uses an MIT license.