Skip to content

Commit

Permalink
package.json: sync gopls settings ([email protected])
Browse files Browse the repository at this point in the history
and pin dlv version used for testing to v1.21.0
to unbreak the debug testing.

Updates golang#2999

Change-Id: If66962ae23b1af6530840937517a97802d654b88
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/533316
Reviewed-by: Suzy Mueller <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
TryBot-Result: kokoro <[email protected]>
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
  • Loading branch information
hyangah committed Oct 6, 2023
1 parent b9cfe62 commit 75f9d50
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 1 deletion.
10 changes: 10 additions & 0 deletions docs/settings.md
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,16 @@ Example Usage:
| `tidy` | Runs `go mod tidy` for a module. <br/> Default: `true` |
| `upgrade_dependency` | Upgrades a dependency in the go.mod file for a module. <br/> Default: `true` |
| `vendor` | Runs `go mod vendor` for a module. <br/> Default: `true` |
### `ui.completion.completeFunctionCalls`

completeFunctionCalls enables function call completion.

When completing a statement, or when a function return type matches the
expected of the expression being completed, completion may suggest call
expressions (i.e. may include parentheses).


Default: `true`
### `ui.completion.completionBudget`

(For Debugging) completionBudget is the soft latency goal for completion requests. Most
Expand Down
6 changes: 6 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2211,6 +2211,12 @@
}
}
},
"ui.completion.completeFunctionCalls": {
"type": "boolean",
"markdownDescription": "completeFunctionCalls enables function call completion.\n\nWhen completing a statement, or when a function return type matches the\nexpected of the expression being completed, completion may suggest call\nexpressions (i.e. may include parentheses).\n",
"default": true,
"scope": "resource"
},
"ui.completion.completionBudget": {
"type": "string",
"markdownDescription": "(For Debugging) completionBudget is the soft latency goal for completion requests. Most\nrequests finish in a couple milliseconds, but in some cases deep\ncompletions can take much longer. As we use up our budget we\ndynamically reduce the search scope to ensure we return timely\nresults. Zero means unlimited.\n",
Expand Down
3 changes: 2 additions & 1 deletion tools/installtools/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ var tools = []struct {
{"github.com/zmb3/gogetdoc", "", false, nil},
{"honnef.co/go/tools/cmd/staticcheck", "", false, []finalVersion{{16, "v0.2.2"}, {18, "v0.3.3"}}},
{"golang.org/x/tools/cmd/gorename", "", false, nil},
{"github.com/go-delve/delve/cmd/dlv", "", false, []finalVersion{{16, "v1.8.3"}, {17, "v1.9.1"}}},
// TODO(golang/vscode-go#2999): v1.21.1 breaks dlv-dap testing.
{"github.com/go-delve/delve/cmd/dlv", "", false, []finalVersion{{16, "v1.8.3"}, {17, "v1.9.1"}, {100, "v1.21.0"}}},
}

// pickVersion returns the version to install based on the supported
Expand Down

0 comments on commit 75f9d50

Please sign in to comment.