Fixing interlock when activating flag GPMF_FLAGS_STORE_ALL_TIMESTAMPS #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree you have found a problem, and very close to the correct solution. This should not be preserving any of the incoming flags, but yes, GPMF_FLAGS_LOCKED should be set. I have added this fix to the develop branch. Can you confirm on that branch that all is working as expected. |
|
I have tested your updated fix and it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
The lock flag was not correctly added to the
stampflagsvariable causing an interlock on the recursive call.@dnewman-gpsw Could you please review this patch.