Skip to content

Commit

Permalink
Hack? to fix failing macOS-3.10 tests
Browse files Browse the repository at this point in the history
`<=` instead of `==`, because in some cases, we seem to get some extra events???

E.g.: https://github.com/gorakhargosh/watchdog/actions/runs/6473427100/job/17576095114#step:5:372

Note, I am on an M1 Mac with OS X 12.6.8 (GitHub Actions above used OS X
12.7) and I used Python 3.10.13 (same as GitHub Actions above) and I
could not reproduce this:

```
$ python -V
Python 3.10.13

$ python -m tox -e py
...
====================================== 161 passed, 8 skipped, 1 xfailed, 2 xpassed in 90.80s (0:01:30) =======================================
.pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
  py: OK (92.48=setup[1.17]+cmd[91.31] seconds)
  congratulations :) (93.22 seconds)
```
  • Loading branch information
msabramo committed Oct 25, 2023
1 parent 6cdf07e commit f377c27
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/test_observers_polling.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ def test___init__(event_queue, emitter):
except Empty:
break

assert expected == got
# <= instead of ==, because in some cases, we seem to get some extra events???
assert expected <= got


def test_delete_watched_dir(event_queue, emitter):
Expand Down

0 comments on commit f377c27

Please sign in to comment.