Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes a possible race condition in AutoRestartTrick #1002

Merged
merged 2 commits into from
Jul 28, 2024
Merged

fixes a possible race condition in AutoRestartTrick #1002

merged 2 commits into from
Jul 28, 2024

Commits on Aug 10, 2023

  1. fixes a possible race condition in AutoRestartTrick 

    Just a long shot for a failure observed on gorakhargosh#998. My hypothesis is that
when we stop ProcessWatcher before we restart the process manually, we
don't yield to it and immediately kill the process. Next, when the
ProcessWatcher thread is woken up, we have to conditions ready - the
popen_obj and stopped_event, see the corresponding code, ``` while
True: if self.popen_obj.poll() is not None: break if
self.stopped_event.wait(timeout=0.1): return ```

And desipte that `stopped_event` is set, we first check for
`popen_obj` and trigger the process restart.

We can also make the ProcessWatcher logic more robust, by checking if
we are stopped before calling the termination callback, e.g.,

```
        try:
            if not self.stopped_event.is_set():
                self.process_termination_callback()
        except Exception:
            logger.exception("Error calling process termination callback")
```

I am not 100% sure about that, as I don't really know what semantics
is expected from ProcessWatcher by other users. But at least the
AutoRestarter expects this semantics - i.e., a watcher shall not call
any events after it was stopped.
    @ivg
    ivg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    bf1e269 View commit details
    Browse the repository at this point in the history

  2. tries an alternative solution 

    i.e., don't send events if stopped
    @ivg
    ivg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    f8c9cb0 View commit details
    Browse the repository at this point in the history