Fix a silent fail if path is a file #1034 (Windows only). #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasRzepka
force-pushed
the
master
branch
from
661d7e2
to
a3bf6fe
Compare
BoboTiG
reviewed
Oct 4, 2024
|
Use cache for "is file". Rebased and squashed. |
|
@BoboTiG : Anything else what I missed? |
|
Thanks for your work @TobiasRzepka, it's taking time because I am not sure about the implementation. I am a little bit concerned about potential performances impact. I might come again later with some free time, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateFileW can only track directories, not files. In case of files, start tracking the directory and filter out files which are not tracked.
Fixes #1034.