Delayed clearing of event records from moved_events dictionary in a separate daemon thread #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are used for source_path acquisition with some delay for events not to get cleaned before they have a chance to be used as moved_from. Dict optimized to hold smaller object with only src_path and timestamp. Unfortunately a thread breaks some pytest fixtures in place, so I added a "threaded" folder where such test could be moved as an example if this approach is to be accepted
ksiv
changed the title
ksiv
changed the title
|
I made a new one with non-demon thread |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added separate daemon thread to clean records from moved_events that are used for source_path acquisition with some delay for events not to get cleaned before they have a chance to be used as for source_path acquisition
Dict optimized to hold smaller object with only src_path and timestamp.
Unfortunately a thread breaks some pytest fixtures in place, so I added a "threaded" folder where such test could be moved as an example if this approach is to be accepted
This PR supposed to deal with #1041
And possibly partly with #587